rbac: apply the shadow_rules_stat_prefix to shadow stats in addition to dynamic metadata#15391
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Mar 12, 2021
Merged
rbac: apply the shadow_rules_stat_prefix to shadow stats in addition to dynamic metadata#15391mattklein123 merged 2 commits intoenvoyproxy:mainfrom
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
Conversation
…to dynamic metadata Signed-off-by: Yangmin Zhu <ymzhu@google.com>
mattklein123
requested changes
Mar 11, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks this makes sense to me with small comment.
/wait
|
|
||
| The RBAC network filter outputs statistics in the *<stat_prefix>.rbac.* namespace. | ||
|
|
||
| For the shadow rule statistics `shadow_allowed` and `shadow_denied`, the :ref:`shadow_rules_stat_prefix <envoy_v3_api_field_extensions.filters.http.rbac.v3.RBAC.shadow_rules_stat_prefix>` |
Member
There was a problem hiding this comment.
Copy/paste issue here for the field? Should point to network filter? Same below?
Contributor
Author
There was a problem hiding this comment.
Ah, thanks for catching. Updated both.
Signed-off-by: Yangmin Zhu <ymzhu@google.com>
aunu53
pushed a commit
to aunu53/envoy
that referenced
this pull request
Mar 19, 2021
…to dynamic metadata (envoyproxy#15391) Signed-off-by: Yangmin Zhu <ymzhu@google.com> Signed-off-by: Auni Ahsan <auni@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my original PR (#15323), I intended to only apply the prefix to the dynamic metadata key emitted by the shadow_rules. However, looking at the current API description, the normal understanding is it should also apply to the normal
shadow_allowedandshadow_deniedstats. This PR adds the support for this.We could add another field
shadow_rules_dynamic_metadata_prefixin the API to allow configuring these separately but I'm not sure if people would ever need a different prefix for the same shadow rules. I can add it if it makes sense to anyone.cc @mattklein123 who reviewed the last PR.
Commit Message: Apply the shadow_rules_stat_prefix to shadow stats in addition to dynamic metadata.
Additional Description: N/A
Risk Level: Low
Testing: Unit Tests
Docs Changes: Updated the RBAC filter documentation
Release Notes: N/A
Platform Specific Features: N/A